Set deadpool config size to 4 conns #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change for server connection pool performance. We only use the Redis connection pool to optimize immediate `GET` and `SET` operations, which should be very fast, so it doesn't make sense to keeping too many idle connections in the pool. Deadpool's connection pool only configures the number of slots that are maintained for connections to be recycled, so this is fine. Unlike other pools, this will still create more Redis connections if we hit the max pool size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change for server connection pool performance. We only use the Redis connection pool to optimize immediate
GETandSEToperations, which should be very fast, so it doesn't make sense to keeping too many idle connections in the pool.Deadpool's connection pool only configures the number of slots that are maintained for connections to be recycled, so this is fine. Unlike other pools, this will still create more Redis connections if we hit the max pool size.