Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FreeBSD enhancement #67

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

aokblast
Copy link
Contributor

@aokblast aokblast commented Jan 4, 2024

This patch add two things:

  1. As FreeBSD use /usr/local/bin to install 3rd software, I add it into the shell search path.
  2. Add FreeBSD build support. Currently, there is no cross-compile toolchain for FreeBSD in MacOS. And for simplicity, I use cross-rs to cross compile. And next, Aarch64 for FreeBSD is in tier-3 supported and is nightly only in rust. So it maybe too complicate to run the cross-compilation in cross-rs so I don't do it.

I have tested the release.sh in my M1 Macbook and it works fine.

@aokblast aokblast force-pushed the feat/BSDEnhancement branch 2 times, most recently from a785f2a to bc706f0 Compare January 4, 2024 20:30
Because OS like *BSD tends to install 3rd software into /usr/local/bin instead of /bin, so I think we should add it as the default search path
@ekzhang
Copy link
Owner

ekzhang commented Sep 22, 2024

Thank you! Sorry for missing this.

@ekzhang ekzhang enabled auto-merge (squash) September 22, 2024 14:35
@ekzhang ekzhang merged commit 426e7c4 into ekzhang:main Sep 22, 2024
3 checks passed
@aokblast
Copy link
Contributor Author

Ah, Thank you! I also don't remember I used to have submitted such patch:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants