Skip to content

Commit

Permalink
Merge pull request #324 from EiPiFun/master
Browse files Browse the repository at this point in the history
Fix typo, add HEVC support description, add open gpu kernel info
  • Loading branch information
elFarto authored Sep 9, 2024
2 parents f3205bd + e53dae2 commit 54442d8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ Environment variables used to control the behavior of this library.

## Firefox

Due to license, Firefox on Linux does not support HEVC till now.
To use the driver with firefox you will need at least Firefox 96, `ffmpeg` compiled with vaapi support (`ffmpeg -hwaccels` output should include vaapi), and the following config options need to be set in the `about:config` page:

| Option | Value | Reason |
Expand Down Expand Up @@ -165,4 +166,4 @@ To verify that the driver is being used to decode video, you can use nvidia-sett

- nvidia-smi

Running `nvidia-smi` while decoding a video should show a Firefox process with `C` in the `Type` column. In addition `nvidia-smi pmon` will show the usage of the decode engine per-process, and `nvidia-smi dmon` will show the usage per-GPU.
Running `nvidia-smi` while decoding a video should show a Firefox process with `C` in the `Type` column. In addition `nvidia-smi pmon` will show the usage of the decode engine per-process, and `nvidia-smi dmon` will show the usage per-GPU. When using nvidia open gpu kernel modules, the usage of the decode engine may not be displayed correctly.
2 changes: 1 addition & 1 deletion src/export-buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ static void egl_detachBackingImageFromSurface(NVDriver *drv, NVSurface *surface)

if (surface->backingImage->fourcc == DRM_FORMAT_NV21) {
if (!egl_destroyBackingImage(drv, surface->backingImage)) {
LOG("Unable to destory backing image");
LOG("Unable to destroy backing image");
}
} else {
pthread_mutex_lock(&drv->imagesMutex);
Expand Down

0 comments on commit 54442d8

Please sign in to comment.