Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #133

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Update README #133

merged 3 commits into from
Dec 9, 2022

Conversation

crimist
Copy link
Contributor

@crimist crimist commented Dec 7, 2022

  • Update firefox EGL conf to mention direct backend.
  • Update direct backend grammar and compatibility list.

@elFarto
Copy link
Owner

elFarto commented Dec 7, 2022

The EGL backend being referred to is Firefox's EGL backend, rather than it's GLX one. Firefox can use this driver's EGL or direct backend without issue.

I do agree that description does need rewording as having a second 'EGL backend' is confusing.

@crimist
Copy link
Contributor Author

crimist commented Dec 8, 2022

Ah I see, I just assumed (and found it true) that the MOZ_X11_EGL didn't need to be set with the direct backend.

Would you be open to some work on the README? I could add a table of contents and clean it up a little.

@elFarto
Copy link
Owner

elFarto commented Dec 8, 2022

It's likely that EGL doesn't need to be forced for recent versions of Firefox, as I believe it's now the default. When the library was initially released that wasn't the case.

I would absolutely be open to the README being worked on.

@crimist crimist force-pushed the patch-1 branch 2 times, most recently from de17bda to 9d59a3c Compare December 9, 2022 00:15
Add table of contents, more comprehensive installation guide, and general clean up of documentation
@crimist
Copy link
Contributor Author

crimist commented Dec 9, 2022

What is the minimum NVIDIA driver version required for this package? Probably worth mentioning in the installation section to reduce issues like #136.

@crimist
Copy link
Contributor Author

crimist commented Dec 9, 2022

Nevermind, I see it's 470 or 500+ drivers.

* fix issue & PR links
* improve structure and readability
@elFarto
Copy link
Owner

elFarto commented Dec 9, 2022

Thanks, those changes look good!

@elFarto elFarto merged commit 3016067 into elFarto:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants