-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto set the footer year #121
Conversation
@rdmdk Awesome, cheers 🎉 💯 . It's live! |
@eladnava fantastic! have some ideas for other improvements but unsure how to implement (e.g. adding data-attributes to the html to indicate the webpage is being loaded inside an extension - not sure if that's even doable) |
@rdmdk What would be the intended behavior in that case? Are you trying to make it possible for websites to detect they are being Applicationized and behave/display differently? |
@eladnava I've applicationized a few of my own webapps and in some rare instances, they behaved differently. For example, on window.prompt(a, b), b does not display. If the html tag were to be coded as html data-crx or html data-extension, I could work around this or just omit that functionality entirely whenever the app loads inside of an extension. |
Unfortunately, that has to do with issue #36. There is no easy/clean way to resolve it unfortunately (but a workaround is mentioned in that issue). |
The workaround: |
Workaround: especially if you're Applicationizing your own web apps: URL: https://exampleurl.com?crx JS:
|
Instead of bumping it every year