Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto set the footer year #121

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Auto set the footer year #121

merged 4 commits into from
Mar 8, 2021

Conversation

rdmdk
Copy link
Contributor

@rdmdk rdmdk commented Mar 7, 2021

Instead of bumping it every year

@eladnava eladnava merged commit a03c572 into eladnava:master Mar 8, 2021
@eladnava
Copy link
Owner

eladnava commented Mar 8, 2021

@rdmdk Awesome, cheers 🎉 💯 . It's live!

@rdmdk
Copy link
Contributor Author

rdmdk commented Mar 8, 2021

@eladnava fantastic! have some ideas for other improvements but unsure how to implement (e.g. adding data-attributes to the html to indicate the webpage is being loaded inside an extension - not sure if that's even doable)

@eladnava
Copy link
Owner

eladnava commented Mar 8, 2021

@rdmdk What would be the intended behavior in that case? Are you trying to make it possible for websites to detect they are being Applicationized and behave/display differently?

@rdmdk
Copy link
Contributor Author

rdmdk commented Mar 8, 2021

@eladnava I've applicationized a few of my own webapps and in some rare instances, they behaved differently. For example, on window.prompt(a, b), b does not display. If the html tag were to be coded as html data-crx or html data-extension, I could work around this or just omit that functionality entirely whenever the app loads inside of an extension.

@eladnava
Copy link
Owner

eladnava commented Mar 8, 2021

Unfortunately, that has to do with issue #36. There is no easy/clean way to resolve it unfortunately (but a workaround is mentioned in that issue).

@eladnava
Copy link
Owner

eladnava commented Mar 8, 2021

The workaround:
#25 (comment)

@rdmdk
Copy link
Contributor Author

rdmdk commented Mar 10, 2021

Workaround: especially if you're Applicationizing your own web apps:

URL: https://exampleurl.com?crx

JS:

if (localStorage.crx) document.body.setAttribute('data-crx', '');
else if (window.location.href.includes('crx')) {
	localStorage.crx = true;
	window_location.href = '/'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants