Fix seeking in review & trim step #1186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims at fixing or at least helping with #517.
As suggested in #517, this introduces the webm-duration-fix package to Studio. This should fix the "Preview & Trim" step on Chrome (desktop), allowing for playback and seeking in the recorded video. Furthermore, the duration should now be stored correctly in the video metadata.
This should not change behaviour in Firefox, as it was already working in Firefox. I have not tested other browsers. I have also only tested this with short (~1 minute) recordings.
Note that recordings downloaded directly from Chrome may still not be playable by all and every media player. This is not something this PR can fix.