Only add perms with write or owner permission in backend

elan-ev · Oct 11, 2023 · e03620a · e03620a
1 parent b76cbe9
commit e03620a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/lib/Routes/Playlist/PlaylistVideoList.php b/lib/Routes/Playlist/PlaylistVideoList.php
@@ -53,9 +53,11 @@ public function __invoke(Request $request, Response $response, $args)
 
         $ret = [];
         foreach ($videos['videos'] as $video) {
-            # TODO Who has access to the perms list? currently everyone (frontend needs to handle this)
             $video_array = $video->toSanitizedArray($params['cid'], $playlist->id);
-            $video_array['perms'] = $video->perms->toSanitizedArray();
+            if (!empty($video_array['perm']) && ($video_array['perm'] == 'owner' || $video_array['perm'] == 'write'))
+            {
+                $video_array['perms'] = $video->perms->toSanitizedArray();
+            }
             $ret[] = $video_array;
         }
 

diff --git a/lib/Routes/Video/VideoList.php b/lib/Routes/Video/VideoList.php
@@ -24,9 +24,11 @@ public function __invoke(Request $request, Response $response, $args)
 
         $ret = [];
         foreach ($videos['videos'] as $video) {
-            # TODO Who has access to the perms list? currently everyone (frontend needs to handle this)
             $video_array = $video->toSanitizedArray();
-            $video_array['perms'] = $video->perms->toSanitizedArray();
+            if (!empty($video_array['perm']) && ($video_array['perm'] == 'owner' || $video_array['perm'] == 'write'))
+            {
+                $video_array['perms'] = $video->perms->toSanitizedArray();
+            }
             $ret[] = $video_array;
         }
 

diff --git a/vueapp/components/Videos/VideoCard.vue b/vueapp/components/Videos/VideoCard.vue
@@ -253,9 +253,11 @@ export default {
 
         getAccessText() {
             var txt = '';
-            this.event.perms.forEach(perm => {
-                txt += '<div>' + perm.fullname + ': ' + perm.perm + '</div>'
-            });
+            if (this.event?.perms) {
+                this.event.perms.forEach(perm => {
+                    txt += '<div>' + perm.fullname + ': ' + perm.perm + '</div>'
+                });
+            }
             return txt;
         },