Clear errors when success message is displayed #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis531
added
v:3
|
Es sollten keine Erfolgsmeldungen zusammen mit Fehlermeldungen auftreten, falls doch, wäre das ein Bug. Wenn etwas fehlgeschlagen ist, gibt es nur einen Fehler und nur wenn alles geklappt hat eine Erfolgsmeldung. Meines Erachtens ist das mit diesem PR eingeführte Verhalten in Ordnung und sinnvoll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Änderung:
Bei dieser Änderung war ich mir nicht ganz sicher, ob wir dieses Verhalten wirklich haben wollen. Hier stellt sich die Frage, ob Fehler- und Erfolgsnachrichten gleichzeitig auftreten können?
Closes #705