-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic::client::requests::document_index::Pending does not have method then() #414
Comments
My elastic library version is |
Sorry for the late response. It looks like from your other issue, elastic/elasticsearch-rs#102, you are using futures This repo is not compatible with futures If you need to stick with this crate, you can try using tokio-compat or futures 0.1, but it might end up being more work than migrating over to the official client... |
Updates to latest localstack tag. I need this for some of the S3+SQS work, but figured I'd do it separately. The biggest change is that localstack now exposes all services on the same port, 4566, simplifying our setup. Additional changes due to localstack changes: I updated `aws_s3` sink tests to use "Identity" for Content-Encoding as this appears to be the default encoding now I added a sleep in `aws_kinesis_streams` test to allow localstack to fully create the stream (it was getting `ResourceNotFound` errors when the sink tried to publish via `PutRecords`). I tried a `wait_for` with `DescribeStream`, but the stream was successfully returned by that before it was ready, still. I updated `aws_kinesis_firehose` to create the Elasticsearch domain as localstack now lazily starts Elasticsearch upon domain creation. I updated `aws_kinesis_firehose` tests to just deserialize requests directly rather than using `elastic_responses` (which allowed me to drop this dependency). The localstack update included an ES update which caused me to run into elastic-rs/elastic#361 . I was going to update `elastic_responses` to include this change but the `elastic_responses` crate was dropped in newer versions of that repo. I then attempted to switch to the actual client that repo provides but ran into async issues with it depending on futures01 (elastic-rs/elastic#414). That Github issue for that indicated to me that it seems like that repo was being deprecated in-lieu of the official client. Given we only needed an exceedingly small subset of functionality, I just decided to parse it with `serde_json::Value` rather than switch to the new crate; however, that seems like the preferred option for the future is an option for the future if we come to need a more robust ES integration. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Updates to latest localstack tag. I need this for some of the S3+SQS work, but figured I'd do it separately. The biggest change is that localstack now exposes all services on the same port, 4566, simplifying our setup. Additional changes due to localstack changes: I updated `aws_s3` sink tests to use "Identity" for Content-Encoding as this appears to be the default encoding now I added a sleep in `aws_kinesis_streams` test to allow localstack to fully create the stream (it was getting `ResourceNotFound` errors when the sink tried to publish via `PutRecords`). I tried a `wait_for` with `DescribeStream`, but the stream was successfully returned by that before it was ready, still. I updated `aws_kinesis_firehose` to create the Elasticsearch domain as localstack now lazily starts Elasticsearch upon domain creation. I updated `aws_kinesis_firehose` tests to just deserialize requests directly rather than using `elastic_responses` (which allowed me to drop this dependency). The localstack update included an ES update which caused me to run into elastic-rs/elastic#361 . I was going to update `elastic_responses` to include this change but the `elastic_responses` crate was dropped in newer versions of that repo. I then attempted to switch to the actual client that repo provides but ran into async issues with it depending on futures01 (elastic-rs/elastic#414). That Github issue for that indicated to me that it seems like that repo was being deprecated in-lieu of the official client. Given we only needed an exceedingly small subset of functionality, I just decided to parse it with `serde_json::Value` rather than switch to the new crate; however, that seems like the preferred option for the future is an option for the future if we come to need a more robust ES integration. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
* chore(ci): Update localstack Updates to latest localstack tag. I need this for some of the S3+SQS work, but figured I'd do it separately. The biggest change is that localstack now exposes all services on the same port, 4566, simplifying our setup. Additional changes due to localstack changes: I updated `aws_s3` sink tests to use "Identity" for Content-Encoding as this appears to be the default encoding now I added a sleep in `aws_kinesis_streams` test to allow localstack to fully create the stream (it was getting `ResourceNotFound` errors when the sink tried to publish via `PutRecords`). I tried a `wait_for` with `DescribeStream`, but the stream was successfully returned by that before it was ready, still. I updated `aws_kinesis_firehose` to create the Elasticsearch domain as localstack now lazily starts Elasticsearch upon domain creation. I updated `aws_kinesis_firehose` tests to just deserialize requests directly rather than using `elastic_responses` (which allowed me to drop this dependency). The localstack update included an ES update which caused me to run into elastic-rs/elastic#361 . I was going to update `elastic_responses` to include this change but the `elastic_responses` crate was dropped in newer versions of that repo. I then attempted to switch to the actual client that repo provides but ran into async issues with it depending on futures01 (elastic-rs/elastic#414). That Github issue for that indicated to me that it seems like that repo was being deprecated in-lieu of the official client. Given we only needed an exceedingly small subset of functionality, I just decided to parse it with `serde_json::Value` rather than switch to the new crate; however, that seems like the preferred option for the future is an option for the future if we come to need a more robust ES integration. Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Remove elastic_responses from elasticsearch sink tests Also fix port number for Elasticsearch and use normal localstack image. I had been using `-full` to verify that not using it was causing a failure but this turned out not to be the case. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
* chore(ci): Update localstack Updates to latest localstack tag. I need this for some of the S3+SQS work, but figured I'd do it separately. The biggest change is that localstack now exposes all services on the same port, 4566, simplifying our setup. Additional changes due to localstack changes: I updated `aws_s3` sink tests to use "Identity" for Content-Encoding as this appears to be the default encoding now I added a sleep in `aws_kinesis_streams` test to allow localstack to fully create the stream (it was getting `ResourceNotFound` errors when the sink tried to publish via `PutRecords`). I tried a `wait_for` with `DescribeStream`, but the stream was successfully returned by that before it was ready, still. I updated `aws_kinesis_firehose` to create the Elasticsearch domain as localstack now lazily starts Elasticsearch upon domain creation. I updated `aws_kinesis_firehose` tests to just deserialize requests directly rather than using `elastic_responses` (which allowed me to drop this dependency). The localstack update included an ES update which caused me to run into elastic-rs/elastic#361 . I was going to update `elastic_responses` to include this change but the `elastic_responses` crate was dropped in newer versions of that repo. I then attempted to switch to the actual client that repo provides but ran into async issues with it depending on futures01 (elastic-rs/elastic#414). That Github issue for that indicated to me that it seems like that repo was being deprecated in-lieu of the official client. Given we only needed an exceedingly small subset of functionality, I just decided to parse it with `serde_json::Value` rather than switch to the new crate; however, that seems like the preferred option for the future is an option for the future if we come to need a more robust ES integration. Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Remove elastic_responses from elasticsearch sink tests Also fix port number for Elasticsearch and use normal localstack image. I had been using `-full` to verify that not using it was causing a failure but this turned out not to be the case. Signed-off-by: Jesse Szwedko <jesse@szwedko.me> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
My code starting on line 169:
My error message:
I do have this
use
line in my file:The text was updated successfully, but these errors were encountered: