Add additional meta fields to DocumentType #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could also clean up the client methods by wrapping the document type in a separate method so that generics can be used: client.document::<MyType>().get(33).send()?;instead of: client.document_get::<MyType>(Id::from(33)).send()?;That would make it clearer how |
|
Will need to figure out what the docs should look like for this change to the document methods. |
KodrAus
force-pushed
the
feat/enhanced-doc-type-expansion
branch
from
6614037 to
0d6f05a
Compare
- index - ty - id These can be used by the various high-level APIs to extract values when available
KodrAus
force-pushed
the
feat/enhanced-doc-type-expansion
branch
from
0d6f05a to
452f87b
Compare
Open
KodrAus
changed the title
|
This also includes some movement towards supporting Elasticsearch 6.0, but we'll need to build out more document type integration tests to be confident that stuff is correct. Once this merges we should push |
KodrAus
added a commit
that referenced
this pull request
Jan 25, 2019
* add meta fields to document type * add partial static methods * refactor request paths for better inference * update for Elasticsearch 6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #301
Closes #302
Closes #308
Closes #313
Includes
index,tyandid. This allows us to infer the values for these document type specific fields in high-level APIs taking aT: DocumentTypeinstead of requiring them everywhere.It's part of a long-overdue revamp of the
DocumentTypetrait design.