Add ready to make pr tool

[strawgate]

Let's add a tool that runs a shell script, the agent will call the tool before it pushes to a branch or makes a PR

All it will do is tell the agent to review the contributing guide, follow the PR template and ensure they've completed the task that was assigned.

[github-actions]

TL;DR: adding a shared preflight script + prompt rule is the right approach, and the lowest-risk place to wire it is the existing PR/push safe-output fragments so every PR-capable workflow gets the check consistently.

Recommendation
Implement a ready-to-make-pr preflight script and require agents to run it immediately before create_pull_request / push_to_pull_request_branch.

Concretely:

1. Add a repo script (for example scripts/ready-to-make-pr.sh) that checks:
   • whether a contributing guide exists (and prints path if found),
   • whether a PR template exists,
   • whether the task request was addressed (basic git/status + changed-file sanity checks).
2. Update shared safe-output fragments to require running this script before PR/push calls.
3. Import those updated fragments where PR/push tools are enabled (already centralized, so this scales well).

Findings

• PR creation and PR-branch push behavior is already centralized in shared fragments:
  • .github/workflows/gh-aw-fragments/safe-output-create-pr.md:7-16
  • .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md:6-12
• Those fragments are imported by all PR-capable workflow sources:
  • Create PR importers: .github/workflows/gh-aw-bug-exterminator.md:11, gh-aw-code-simplifier.md:11, gh-aw-downstream-users.md:11, gh-aw-small-problem-fixer.md:11, gh-aw-test-improvement.md:11, gh-aw-mention-in-issue.md:12, gh-aw-issue-triage-pr.md:12
  • Push-to-PR importers: .github/workflows/gh-aw-mention-in-pr.md:15, gh-aw-pr-checks-fix.md:12, gh-aw-pr-ci-fixer.md:12
• Existing prompts already tell agents when to PR/push, but there is no explicit “ready-to-make-pr” preflight gate:
  • .github/workflows/gh-aw-mention-in-issue.md:92-93
  • .github/workflows/gh-aw-mention-in-pr.md:90
  • .github/workflows/gh-aw-pr-checks-fix.md:86
• This repo currently has no CONTRIBUTING* file and no PR template file, so the script should handle “not present” cleanly instead of hard-failing in this repo.
• Related precedent: issue Ensure code workflows run required commands #135 / PR Require repo commands in workflow prompts #141 standardized “run required repo commands” language across multiple prompts, showing this repo already uses shared prompt updates for cross-workflow policy.

Verification

I validated current behavior by inspecting workflow sources and fragments:

$ rg "gh-aw-fragments/safe-output-create-pr\.md" .github/workflows/gh-aw-*.md
...7 workflow sources import the create-pr fragment

$ rg "gh-aw-fragments/safe-output-push-to-pr\.md" .github/workflows/gh-aw-*.md
...3 workflow sources import the push-to-pr fragment

$ glob "**/CONTRIBUTING*"
No files matched the pattern.

$ glob ".github/**/*template*"
No files matched the pattern.

And I checked the relevant files directly:

• .github/workflows/gh-aw-fragments/safe-output-create-pr.md
• .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md
• .github/workflows/gh-aw-mention-in-issue.md
• .github/workflows/gh-aw-mention-in-pr.md
• .github/workflows/gh-aw-pr-checks-fix.md

Detailed Action Plan

1. Add preflight script

   • Create scripts/ready-to-make-pr.sh.
   • Script output should be explicit and machine/human readable (PASS/WARN/FAIL lines).
   • Checks:
     • locate contributing docs (CONTRIBUTING.md, docs/contributing*, etc.),
     • locate PR templates (.github/pull_request_template.md, .github/PULL_REQUEST_TEMPLATE/*.md),
     • ensure there is substantive workspace change relative to task (at minimum: non-empty diff and not only metadata changes).

2. Wire policy into shared fragment prompts

   • Update .github/workflows/gh-aw-fragments/safe-output-create-pr.md to require:
     • bash scripts/ready-to-make-pr.sh before create_pull_request,
     • abort PR creation when script returns non-zero.
   • Update .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md similarly for push_to_pull_request_branch.

3. Compile and verify

   • Run make compile (per gh-agent-workflows/DEVELOPING.md:125-132) to regenerate lock files.
   • Spot-check generated lock workflows that expose these tools (especially gh-aw-mention-in-issue.lock.yml, gh-aw-issue-triage-pr.lock.yml, gh-aw-mention-in-pr.lock.yml, gh-aw-pr-checks-fix.lock.yml, gh-aw-pr-ci-fixer.lock.yml).

4. Document behavior

   • Add one short note in relevant workflow READMEs (at least gh-agent-workflows/mention-in-issue/README.md, gh-agent-workflows/issue-triage-pr/README.md, gh-agent-workflows/mention-in-pr/README.md, gh-agent-workflows/pr-checks-fix/README.md) that PR/push actions run a readiness preflight.

Related Items

Type	Link	Relevance
Issue	#208	Current request
Issue	#135	Prior cross-workflow prompt policy standardization
PR	#141	Implemented #135 by updating multiple workflow prompts
PR	#169	Added issue-triage-pr workflow with PR capability
File	.github/workflows/gh-aw-fragments/safe-output-create-pr.md:7-16	Central create-PR guardrails
File	.github/workflows/gh-aw-fragments/safe-output-push-to-pr.md:6-12	Central push-to-PR guardrails
File	.github/workflows/gh-aw-mention-in-issue.md:12,92-93	Uses create-PR fragment; PR call guidance
File	.github/workflows/gh-aw-mention-in-pr.md:15,90	Uses push fragment; push guidance
File	.github/workflows/gh-aw-pr-checks-fix.md:12,86	Uses push fragment; push guidance

---

What is this? | From workflow: Issue Triage Agent

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #208

[strawgate]

/ai i actually think we want a safe-input see https://github.github.io/gh-aw/reference/safe-inputs/ can you make a PR?

[github-actions]

TL;DR: I opened a PR that adds a shell-backed ready-to-make-pr safe-input preflight and wires it into the PR/push safe-output fragment copies.

What’s included:

• Added scripts/ready-to-make-pr.sh that returns JSON reminders to:
  • review contributing guidance,
  • follow the PR template,
  • confirm the assigned task is complete/validated.
• Added relocation-ready fragment copies under github/workflows/gh-aw-fragments/:
  • safe-output-create-pr.md
  • safe-output-push-to-pr.md
• Both now define safe-input ready-to-make-pr and instruct agents to call ready_to_make_pr before create_pull_request / push_to_pull_request_branch.

Validation run:

• bash scripts/ready-to-make-pr.sh | python -m json.tool
• make lint (passed)

Note: these workflow fragment updates are intentionally in github/ (not .github/workflows/) because workflow-file edits are blocked by this runtime; a maintainer can relocate them into .github/workflows/gh-aw-fragments/.

---

What is this? | From workflow: Issue Assistant

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #208

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• github.github.io