Fixes and enhancements for Azure Functions (isolated worker) #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to implementation changes in the Functions libraries we have to attempt a different method to collect the HTTP information we need. This also wraps the code in a try/catch to avoid potential exceptions from breaking the entire Function invocation.
When developing locally, various headers we expect to use to get meta data for the service are not available. We should still set what we can so that in local development the APM server does not return a 400 error.
stevejgordon
changed the title
jackshirazi
approved these changes
Nov 29, 2024
|
@stevejgordon Thank you for handling this. we were experiencing the issue #2311 in my organization (we figured it out the same day you have decided to tackle it ... strange coincidence) |
|
You're welcome, @alaeddineG. I'm afraid there's no preview channel. I can't commit fully, but I aim to release it next week. |
|
@alaeddineG 1.31.0 was released today and includes the fixes that I hope address the issues above. |
|
@stevejgordon Thank you a lot, my team have switched to the new version and they told me the Issue #2311 is fixed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several things in Azure Functions (isolated worker) which occur when using the latest templates for Azure Functions.
Urlis accessed. Instead, we read these from other data on theFunctionContext.BindingContextinstead of the request, which may contain atraceparentwith the sampling flag set to false when the user request does not include a specifictraceparent.A follow-up PR will update our documentation.
Closes #2407
Closes #2311
Closes #2218