github-action: use ephemeral tokens with the required permissions #1652
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
approved these changes
Sep 9, 2024
reakaleek
approved these changes
Sep 9, 2024
|
I'll merge this as soon as we solve the CLA validation for GitHub Apps |
|
CLA checker will cause some disruptions - I'm working on it with the relevant CLA owners. for now, I'll keep this draft to avoid surprises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
What
Use https://github.com/tibdex/github-app-token to generate ephemeral tokens with the required
permissions only
This is the alternative to moving away from finer-grained GitHub tokens and reducing the
cumbersome of rotating them as we do nowadays.
Implementaiton details
We have used the same GitHub action in other places.
If there are any questions, please reach out to the @elastic/observablt-ci