-
Notifications
You must be signed in to change notification settings - Fork 327
fix two problems in dubbo plugin #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
…value, which will be reproduced when the application invoke a dubbo api in a dubbo transaction.
|
/test |
|
@SylvainJuge Can this PR be merged? |
|
All tests are passed, So what‘s the problem with this PR? what can i do to make this pr to be merged early? |
|
|
|
Thanks a lot for your contribution and sorry for the radio silence. We have not forgotten about this PR but we're currently focussing on the tasks that we have planned for in the current milestone. I'm sorry that your PR didn't make it on that milestone. I'm adding it as a candidate for the next one. |
SylvainJuge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really sorry it took us that long to get to this PR, as the changes are quite straightforward and properly covered with tests. Thanks a lot @CoderLan0668 ! When pushing to this branch I got a notification that it was renamed as dubbo_bak on your fork, are there other changes that we should include here ?
LGTM, I've taken the liberty to switch to using random test ports instead of static ones.
|
@elasticmachine run elasticsearch-ci/docs |
|
@elasticmachine run elasticsearch-ci/docs |
What does this PR do?
to fix two problem in dubbo plugin
Checklist