Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user-agent spec #2177

Merged
merged 8 commits into from
Oct 18, 2021
Merged

Implement user-agent spec #2177

merged 8 commits into from
Oct 18, 2021

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Oct 11, 2021 •
edited
Loading

What does this PR do?

Implements user-agent header change for spec elastic/apm#514.
Allows to ensure the shared gherkin spec is usable and valid, at least for the Java agent.

Checklist

@SylvainJuge SylvainJuge self-assigned this Oct 11, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 11, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-15T14:13:48.786+0000

  • Duration: 61 min 17 sec

  • Commit: 46ff786

Test stats 🧪

Test Results
Failed 0
Passed 2428
Skipped 19
Total 2447

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

@SylvainJuge SylvainJuge marked this pull request as ready for review October 12, 2021 14:31
@SylvainJuge SylvainJuge mentioned this pull request Oct 12, 2021
Closed
@SylvainJuge SylvainJuge merged commit d943484 into elastic:master Oct 18, 2021
@SylvainJuge SylvainJuge deleted the user-agent-spec branch October 18, 2021 07:36
@AlexanderWert AlexanderWert changed the title Implement user-agent spec [META 527] Implement user-agent spec Nov 18, 2021
@AlexanderWert AlexanderWert changed the title [META 527] Implement user-agent spec Implement user-agent spec Nov 18, 2021
@AlexanderWert AlexanderWert linked an issue Nov 18, 2021 that may be closed by this pull request
[META 527] User-agent header for transport #2275
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

Assignees

@SylvainJuge SylvainJuge

Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 527] User-agent header for transport
3 participants
@SylvainJuge @apmmachine @jackshirazi