Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unknown-${service.agent.name}-service instead of my-service #2325

Merged
merged 6 commits into from
Dec 19, 2021

Conversation

tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Dec 8, 2021

What does this PR do?

Fixes #2306

Checklist

… it was not possible to discover a service name
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@github-actions github-actions bot added community Issues and PRs created by the community triage labels Dec 8, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Dec 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-17T16:39:24.193+0000

  • Duration: 70 min 45 sec

  • Commit: 147c788

Test stats 🧪

Test Results
Failed 0
Passed 2639
Skipped 21
Total 2660

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler
Copy link
Contributor Author

@eyalkoren Since the issue is assigned to you, would you please have a look?

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this @tobiasstadler !

@SylvainJuge
Copy link
Member

/test

@eyalkoren
Copy link
Contributor

run elasticsearch-ci/docs

@eyalkoren eyalkoren enabled auto-merge (squash) December 19, 2021 07:06
@eyalkoren eyalkoren merged commit 01d2dc8 into elastic:master Dec 19, 2021
@tobiasstadler tobiasstadler deleted the fix-2306 branch December 19, 2021 08:59
@tobiasstadler
Copy link
Contributor Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 571] Align on default service name
4 participants