Skip to content

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Dec 8, 2021

What does this PR do?

Fixes #2276

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@ghost
Copy link

ghost commented Dec 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-17T16:39:31.937+0000

  • Duration: 44 min 15 sec

  • Commit: 8e15859

Test stats 🧪

Test Results
Failed 0
Passed 2442
Skipped 16
Total 2458

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler
Copy link
Contributor Author

@SylvainJuge Since the issue is assigned to you, would you please have a look?

@SylvainJuge SylvainJuge added this to the 8.1 milestone Jan 4, 2022
@AlexanderWert AlexanderWert removed this from the 8.1 milestone Jan 10, 2022
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify the test setup a bit and make it more consistent with other tests.
Otherwise, LGTM

Note: I have not tested the suggestions.

@felixbarny
Copy link
Member

/test
run elasticsearch-ci/docs

@felixbarny felixbarny enabled auto-merge (squash) January 17, 2022 15:37
@tobiasstadler
Copy link
Contributor Author

run elasticsearch-ci/docs

1 similar comment
@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny merged commit bdbf401 into elastic:master Jan 17, 2022
@tobiasstadler tobiasstadler deleted the fix-2276 branch January 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.2-candidate agent-java community Issues and PRs created by the community triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[META 545] Drop unsampled transactions when connected to APM Server 8.0+

4 participants