Make public API setters fluent #294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
============================================
+ Coverage 71.43% 71.65% +0.21%
+ Complexity 1202 1197 -5
============================================
Files 133 132 -1
Lines 4631 4568 -63
Branches 474 471 -3
============================================
- Hits 3308 3273 -35
+ Misses 1108 1080 -28
Partials 215 215
Continue to review full report at Codecov.
|
|
This is pretty awesome. To support method chaining in 0.7 I was creating extension methods in Kotlin. |
|
Ideally, we should also remove the |
| return null; | ||
| } | ||
|
|
||
| void doSetName(String name) { |
There was a problem hiding this comment.
maybe protected would be a more accurate accessor to these methods?
There was a problem hiding this comment.
I don't think so, as package private is more restrictive. IntelliJ suggests removing the protected qualifier.
|
Any update on this? |
|
It needs some changes to be compatible with the old API which has void return types. After the changes it can be merged :) |
|
thanks for the ping btw |
|
I have confirmed that this also works when using version |
|
|
||
| @Override | ||
| public ElementMatcher<? super TypeDescription> getTypeMatcher() { | ||
| return named("co.elastic.apm.api.SpanImpl").and(not(hasSuperType(named("co.elastic.apm.api.AbstractSpanImpl")))); |
depends on #293