Skip to content

Commit 0f28a16

Browse files
authored
fix: test crash with mongodb@4.1.1 and node v10 (#2303)
mongodb@4.0.0 dropped support for node v10. However, it wasn't until v4.1.1 that it failed in usage with the latest node v10.
1 parent c44cedb commit 0f28a16

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/config.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,9 +732,9 @@ test('disableInstrumentations', function (t) {
732732
if (semver.lt(process.version, '10.0.0') && semver.gte(esVersion, '7.12.0')) {
733733
modules.delete('@elastic/elasticsearch')
734734
}
735-
// require('mongodb') is a hard crash on nodes < 10.4
735+
// As of mongodb@4 only supports node >=v12.
736736
const mongodbVersion = require('../node_modules/mongodb/package.json').version
737-
if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '10.4.0')) {
737+
if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '12.0.0')) {
738738
modules.delete('mongodb')
739739
}
740740

test/instrumentation/modules/mongodb.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ const agent = require('../../..').start({
88
cloudProvider: 'none'
99
})
1010

11-
// require('mongodb') is a hard crash on nodes <10.4
11+
// As of mongodb@4 only supports node >=v12.
1212
const mongodbVersion = require('../../../node_modules/mongodb/package.json').version
1313
const semver = require('semver')
14-
if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '10.4.0')) {
14+
if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '12.0.0')) {
1515
console.log(`# SKIP mongodb@${mongodbVersion} does not support node ${process.version}`)
1616
process.exit()
1717
}

0 commit comments

Comments
 (0)