Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Aug 25, 2021

mongodb@4.0.0 dropped support for node v10. However, it wasn't until
v4.1.1 that it failed in usage with the latest node v10.

mongodb@4.0.0 dropped support for node v10. However, it wasn't until
v4.1.1 that it failed in usage with the latest node v10.
@trentm trentm requested a review from astorm August 25, 2021 20:16
@trentm trentm self-assigned this Aug 25, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 25, 2021
@trentm
Copy link
Member Author

trentm commented Aug 25, 2021

The failure in GH Actions and Jenkins CI was:

    ...
    # disableInstrumentations
    # individual modules -> @elastic/elasticsearch
    /home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/whatwg-url/dist/encoding.js:2
    const utf8Encoder = new TextEncoder();
                        ^

    ReferenceError: TextEncoder is not defined
        at Object.<anonymous> (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/whatwg-url/dist/encoding.js:2:21)

@ghost
Copy link

ghost commented Aug 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-25T20:23:56.619+0000

  • Duration: 19 min 2 sec

  • Commit: 71b9167

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

Trends 🧪

Image of Build Times

Image of Tests

@trentm trentm merged commit 0f28a16 into master Aug 25, 2021
@trentm trentm deleted the trentm/mongodb-only-works-with-v12-now branch August 25, 2021 22:06
dgieselaar pushed a commit to dgieselaar/apm-agent-nodejs that referenced this pull request Sep 10, 2021
mongodb@4.0.0 dropped support for node v10. However, it wasn't until
v4.1.1 that it failed in usage with the latest node v10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants