Skip to content

rewrite 'disableInstrumentations' test in config.test.js to not need so much special casing #3303

@trentm

Description

@trentm

The

test('disableInstrumentations', function (t) {

test in "test/config.test.js" requires a lot of special casing to exclude modules that don't even import in older node versions. This is an annoying and relatively frequent maintenance paper cut. It is obtuse for new prospective contributors of newer module instrumentations.

This test should be refactored to do some basic sanity tests, but otherwise not feel it has to cover every module that is instrumented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions