Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nested tests are ended currectly #857

Open
2 tasks
watson opened this issue Feb 18, 2019 · 4 comments
Open
2 tasks

Ensure nested tests are ended currectly #857

watson opened this issue Feb 18, 2019 · 4 comments
Assignees
Labels
agent-nodejs Make available for APM Agents project planning. ci low hanging fruit

Comments

@watson
Copy link
Contributor

watson commented Feb 18, 2019

See #849 for details

Checklist

  • Update tests
  • Un-pin tape
@Qard
Copy link
Contributor

Qard commented Oct 20, 2019

This has been fixed for awhile. Looks like we forgot to close the issue for it. 😅

@Qard Qard closed this as completed Oct 20, 2019
@watson
Copy link
Contributor Author

watson commented Oct 21, 2019

If it was me I would consider re-opening this. I created this issue because we, if I understood the problem correctly, technically used tape wrong in that we didn't call t.end() for nested tests. This was then inforced in a new version of tape, but because so many people relied on the broken behavior, the change to tape was rolled back. So while it technically works now, I was under the impression that we used it wrong - hence this issue.

@Qard
Copy link
Contributor

Qard commented Oct 21, 2019

Oh, yep. You're right. For some reason I was thinking we had made the change already.

@Qard Qard reopened this Oct 21, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 21, 2019
@trentm trentm self-assigned this Nov 10, 2020
@trentm trentm added [zube]: Backlog agent-nodejs Make available for APM Agents project planning. and removed [zube]: Inbox labels Nov 10, 2020
@trentm
Copy link
Member

trentm commented Jul 27, 2022

I'm not sure what's up here. We are using the latest tape@5 and have some nested tests that don't call t.end() on the top-level test(..., but we don't have errors. Perhaps tape reversed its position on enforcing this? Anyway... we'll get to it sometime, esp. if/when we switch to using node-tap which does enforce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. ci low hanging fruit
Projects
None yet
Development

No branches or pull requests

4 participants