Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin tape as 4.10 breaks test suite #849

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Feb 12, 2019

Prior to 4.10, it was possible to create nested tests without needing to call t.end(). This was considered a bug and the capability was removed in 4.10, however our test suite is currently heavily dependent on this behaviour.

Fixes #845
Fixes #846
Fixes #847

Related tape-testing/tape#459

Prior to 4.10, it was possible to create nested tests without
needing to call `t.end()`. This was considered a bug and the
capability was removed in 4.10, however our test suite is
currently heavily dependent on this behaviour.
@Qard Qard self-assigned this Feb 12, 2019
@Qard Qard requested a review from watson February 12, 2019 20:17
@Qard Qard merged commit e17567b into elastic:master Feb 12, 2019
@Qard Qard deleted the fix-latest-tape branch February 12, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant