-
Notifications
You must be signed in to change notification settings - Fork 238
Add .js to module path #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .js to module path #1711
Conversation
|
💚 CLA has been signed |
|
Thanks for the contribution 🙂 Could you describe a bit more about which issue you're trying to solve? |
|
@watson |
|
jenkins run the tests please |
|
Would you mind signing our Contributor Agreement: https://www.elastic.co/contributor-agreement If you're familiar with how to rename a commit, please also make sure your commit in this PR follows our commit message guidelines. If you don't know how to do this, just let me know I can do it for you. |
|
I have signed Contributor Agreement. Should I do it again? |
8807c5f to
4f79c24
Compare
|
Is commit message ok now? |
|
The commit message looks fine, thank you 👍 Regarding the CLA: I can see that you signed with a different e-mail than the one you used in the git-commit (the one in the git-commit ends with |
|
I have submitted new CLA |
lreuven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix issue with bundlers like @zeit/ncc