Skip to content

Conversation

@vitramir
Copy link
Contributor

@vitramir vitramir commented Apr 7, 2020

Fix issue with bundlers like @zeit/ncc

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 7, 2020

💚 CLA has been signed

@watson
Copy link
Contributor

watson commented Apr 7, 2020

Thanks for the contribution 🙂

Could you describe a bit more about which issue you're trying to solve?

@vitramir
Copy link
Contributor Author

vitramir commented Apr 7, 2020

@watson
Issue is similar to this one vercel/ncc#480
Compiled code can't resolve module without extension when using dynamic imports.

watson
watson previously approved these changes Apr 7, 2020
@watson
Copy link
Contributor

watson commented Apr 7, 2020

jenkins run the tests please

@watson
Copy link
Contributor

watson commented Apr 7, 2020

Would you mind signing our Contributor Agreement: https://www.elastic.co/contributor-agreement

If you're familiar with how to rename a commit, please also make sure your commit in this PR follows our commit message guidelines. If you don't know how to do this, just let me know I can do it for you.

@vitramir
Copy link
Contributor Author

vitramir commented Apr 7, 2020

I have signed Contributor Agreement. Should I do it again?

@vitramir
Copy link
Contributor Author

vitramir commented Apr 7, 2020

Is commit message ok now?

@watson
Copy link
Contributor

watson commented Apr 8, 2020

The commit message looks fine, thank you 👍

Regarding the CLA: I can see that you signed with a different e-mail than the one you used in the git-commit (the one in the git-commit ends with @icedigital.ru). That's why the CLA-checker isn't happy. You either need to use a different e-mail in the commit or sign again using the e-mail ending with @icedigital.ru. Sorry for all the trouble.

@vitramir
Copy link
Contributor Author

vitramir commented Apr 8, 2020

I have submitted new CLA

Copy link

@lreuven lreuven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson watson merged commit db09598 into elastic:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants