Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Jun 30, 2021

This was forgotten in #2112

Checklist

@trentm trentm self-assigned this Jun 30, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 30, 2021
@ghost
Copy link

ghost commented Jun 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Trent Mick

  • Start Time: 2021-06-30T18:15:38.109+0000

  • Duration: 61 min 52 sec

  • Commit: 55b4481

Trends 🧪

Image of Build Times

@trentm
Copy link
Member Author

trentm commented Jun 30, 2021

A note on the failed "apm-ci/branch", ".Status" and "Test" checks there: those are for the branch build (https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/trentm%252Fs3-tav-testing/1/) which was cancelled automatically for the PR build (https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/view/change-requests/job/PR-2136/1/) which did pass. This has to be a bug in the Jenkinsfile et al reporting of results.

@trentm
Copy link
Member Author

trentm commented Jun 30, 2021

https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2136/3/pipeline/406 shows running s3.test.js in the TAV tests, e.g.:

...
[2021-06-30T18:41:03.746Z] node_tests_1  | -- running test "node test/instrumentation/modules/aws-sdk/s3.test.js" with aws-sdk

[2021-06-30T18:41:05.653Z] node_tests_1  | -- running test "node test/instrumentation/modules/aws-sdk/sqs.js" with aws-sdk

[2021-06-30T18:41:10.934Z] node_tests_1  | -- required packages ["aws-sdk@2.931.0"]

[2021-06-30T18:41:10.934Z] node_tests_1  | -- installing ["aws-sdk@2.931.0"]

[2021-06-30T18:41:20.950Z] node_tests_1  | -- running test "node test/instrumentation/modules/aws-sdk/s3.test.js" with aws-sdk

[2021-06-30T18:41:22.466Z] node_tests_1  | -- running test "node test/instrumentation/modules/aws-sdk/sqs.js" with aws-sdk

[2021-06-30T18:41:27.787Z] node_tests_1  | -- required packages ["aws-sdk@2.930.0"]

[2021-06-30T18:41:27.787Z] node_tests_1  | -- installing ["aws-sdk@2.930.0"]
...

@trentm trentm merged commit 8caa56c into master Jun 30, 2021
@trentm trentm deleted the trentm/s3-tav-testing branch June 30, 2021 21:32
dgieselaar pushed a commit to dgieselaar/apm-agent-nodejs that referenced this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants