Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support publishing a snapshot build for each commit to main #3050

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Support publishing a snapshot build for each commit to main #3050

merged 2 commits into from
Dec 12, 2022

Conversation

amannocci
Copy link
Contributor

@amannocci amannocci commented Nov 29, 2022 •
edited by trentm
Loading

Signed-off-by: Adrien Mannocci adrien.mannocci@elastic.co

Description

  • Add support for daily snapshots.

Checklist

  • Implement code

Validation: https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/PR-3050/11/

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 29, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Nov 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-07T08:15:03.937+0000

  • Duration: 24 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 319082
Skipped 0
Total 319082

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@amannocci amannocci force-pushed the feature/daily-snapshots branch 10 times, most recently from 8acc4fa to 7a3a397 Compare December 6, 2022 12:11
@amannocci
Support daily snapshots
05bd3a8 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci changed the title WIP: Support daily snapshots Support daily snapshots Dec 6, 2022
@amannocci amannocci requested review from a team and trentm December 6, 2022 14:41
trentm
trentm requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I have a number of suggested changes to (a) avoid re-using the "build/dist" dir and (b) to drop the "Daily" from the name because this isn't run daily. Let me know if there are any issues with my suggested changes.

.ci/Jenkinsfile Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.ci/snapshoty.yml Outdated Show resolved Hide resolved
.ci/Jenkinsfile Outdated Show resolved Hide resolved
.ci/Jenkinsfile Outdated Show resolved Hide resolved
.ci/Jenkinsfile Outdated Show resolved Hide resolved
.ci/Jenkinsfile Outdated Show resolved Hide resolved
@trentm
Copy link
Member

trentm commented Dec 6, 2022

Oh, I have another question: The published files from this will be:

gs://obtl-artifacts/apm-agent-nodejs/main/elastic-apm-node-${VERSION}-${COMMIT_SHA}.tgz

How will subsequent tooling determine the latest from this bucket? Should this consider adding a commit-time timestamp to the produced artifact? Or perhaps adding a link or a "latest.json" or some marker file in the GCS bucket?

@amannocci
Add suggestions
1be0e73 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci
Copy link
Contributor Author

Oh, I have another question: The published files from this will be:

gs://obtl-artifacts/apm-agent-nodejs/main/elastic-apm-node-${VERSION}-${COMMIT_SHA}.tgz

How will subsequent tooling determine the latest from this bucket? Should this consider adding a commit-time timestamp to the produced artifact? Or perhaps adding a link or a "latest.json" or some marker file in the GCS bucket?

We could rely on the object creation timestamp within the GCS bucket.
The goal is also to provide a small API to filter snapshots.

@amannocci amannocci requested a review from trentm December 7, 2022 08:21
@trentm trentm changed the title Support daily snapshots Support publishing a snapshot build for each commit to main Dec 7, 2022
@amannocci amannocci merged commit d16f350 into main Dec 12, 2022
@amannocci amannocci deleted the feature/daily-snapshots branch December 12, 2022 09:35
v1v added a commit to v1v/apm-agent-nodejs that referenced this pull request Jan 16, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/test-opente…
f7b1c3d 
…lemetry-actions

* upstream/main: (148 commits)
  chore(deps): bump jsonwebtoken and @azure/msal-node (elastic#3087)
  fix bitrot.js dev-util to work for Next.js versions (elastic#3086)
  synchronize json schema specs (elastic#3082)
  chore(deps): bump json5 from 1.0.1 to 1.0.2 (elastic#3085)
  synchronize json schema specs (elastic#3078)
  chore(deps-dev): bump fastify from 4.10.2 to 4.11.0 (elastic#3083)
  chore(deps): bump next (elastic#3081)
  docs: fix header name with sampled flag (elastic#3069)
  3.41.1 (elastic#3077)
  fix: span compression bug where a buffered span would not be sent when an incompressible sibling ended (elastic#3076)
  chore(deps-dev): bump wait-on from 6.0.1 to 7.0.1 (elastic#3075)
  chore(deps-dev): bump undici from 5.12.0 to 5.14.0 (elastic#3068)
  chore(deps-dev): bump got from 11.8.5 to 11.8.6 (elastic#3067)
  chore(deps-dev): bump koa from 2.13.4 to 2.14.1 (elastic#3066)
  chore(deps-dev): bump @hapi/hapi from 21.0.0 to 21.1.0 (elastic#3058)
  chore(deps-dev): bump @fastify/formbody from 7.3.0 to 7.4.0 (elastic#3057)
  3.41.0 (elastic#3064)
  Support publishing a snapshot build for each commit to main (elastic#3050)
  fix: Add `tracestate` to the `TransactionOptions` TypeScript type (elastic#3063)
  fix: avoid IPv4 vs IPv6 ambiguity in default 'serverUrl' by using '127.0.0.1' rather than 'localhost' (elastic#3049)
  ...
@trentm trentm mentioned this pull request Jun 4, 2024
Merged
6 tasks
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@amannocci @fpm-peter
Support publishing a snapshot build for each commit to main (elastic#…
a495134 
…3050)

* Support daily snapshots

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>

* Add suggestions

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amannocci @apmmachine @trentm