Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honour 'usePathAsTransactionName' config var in Next.js instrumentation #3073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trentm
Copy link
Member

@trentm trentm commented Dec 15, 2022

Fixes: #3072

Checklist

  • add a test case

@trentm trentm self-assigned this Dec 15, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 15, 2022
@trentm
Copy link
Member Author

trentm commented Dec 15, 2022

Try this out via:

npm install 'elastic-apm-node@elastic/apm-agent-nodejs#trentm/nextjs-usePathAsTransactionName'

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-15T19:21:58.689+0000

  • Duration: 25 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 320030
Skipped 0
Total 320030

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js instrumentation doesn't honour usePathAsTransactionName config var
2 participants