Skip to content

test: fix s3.test.js failure in Docker on macos due to timeout #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

test: fix s3.test.js failure in Docker on macos due to timeout #3276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
745d94f
test: fix s3.test.js failure in Docker on macos due to timeout
trentm Apr 18, 2023
f65d22f
guards for Node.js <10.7.0
trentm Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/instrumentation/modules/aws-sdk/s3.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ if (process.env.GITHUB_ACTIONS === 'true' && process.platform === 'win32') {
// cannot be tested.

const { execFile } = require('child_process')
const util = require('util')

const tape = require('tape')

Expand All @@ -44,20 +45,24 @@ tape.test('simple S3 usage scenario', function (t) {
TEST_REGION: 'us-east-2'
}
t.comment('executing test script with this env: ' + JSON.stringify(additionalEnv))
console.time && console.time('exec use-s3')
execFile(
process.execPath,
['fixtures/use-s3.js'],
{
cwd: __dirname,
timeout: 10000, // sanity guard on the test hanging
timeout: 20000, // sanity guard on the test hanging
maxBuffer: 10 * 1024 * 1024, // This is big, but I don't ever want this to be a failure reason.
env: Object.assign({}, process.env, additionalEnv)
},
function done (err, stdout, stderr) {
console.timeLog && console.timeLog('exec use-s3')
t.error(err, 'use-s3.js did not error out')
if (err) {
t.comment(`use-s3.js stdout:\n${stdout}\n`)
t.comment(`use-s3.js stderr:\n${stderr}\n`)
t.comment('err: ' + util.inspect(err))
}
t.comment(`use-s3.js stdout:\n${stdout}\n`)
t.comment(`use-s3.js stderr:\n${stderr}\n`)
t.ok(server.events[0].metadata, 'APM server got event metadata object')

// Sort the events by timestamp, then work through each expected span.
Expand Down