Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Apr 20, 2023

Just skip them until Azure/azure-functions-core-tools#3335
is resolved.

This also bumps the azure-functions-core-tools dep and sets up
dependabot for that package.

Refs: #3279

Just skip them until Azure/azure-functions-core-tools#3335
is resolved.

This also bumps the azure-functions-core-tools dep and sets up
dependabot for that package.

Refs: #3279
@trentm trentm self-assigned this Apr 20, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 20, 2023
@trentm trentm merged commit b6eb909 into main Apr 20, 2023
@trentm trentm deleted the trentm/af-test-failure branch April 20, 2023 22:28
trentm added a commit that referenced this pull request May 2, 2023
This removes the workaround added in #3281.
The core issue was fixed in azure-functions-core-tools@4.0.5148

Fixes: #3279
trentm added a commit that referenced this pull request May 3, 2023
This changes the workaround added in #3281.
The core issue with testing with node >=18.x was fixed in azure-functions-core-tools@4.0.5148

However, an issue testing with node v14.0.0 was introduced. We work around this by
just not testing with node v14.0.0. Testing with the latest node v14.x passes.

Refs: #3281
Fixes: #3279
trentm added a commit that referenced this pull request May 16, 2023
This changes the workaround added in #3281.
The core issue with testing with node >=18.x was fixed in azure-functions-core-tools@4.0.5148

However, an issue testing with node v14.0.0 was introduced. We work around this by
just not testing with node v14.0.0. Testing with the latest node v14.x passes.

Refs: #3281
Fixes: #3279
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…c#3281)

Just skip them until Azure/azure-functions-core-tools#3335
is resolved.

This also bumps the azure-functions-core-tools dep and sets up
dependabot for that package.

Refs: elastic#3279
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
This changes the workaround added in elastic#3281.
The core issue with testing with node >=18.x was fixed in azure-functions-core-tools@4.0.5148

However, an issue testing with node v14.0.0 was introduced. We work around this by
just not testing with node v14.0.0. Testing with the latest node v14.x passes.

Refs: elastic#3281
Fixes: elastic#3279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants