fix: Started Supporting response.writableEnded in transaction's context. #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since response.finished property is deprecated as of the newer node versions and another property i.e. response.writableEnded is currently used in place of it. So started supporting reponse.writableEnded in transcation's context. Also, the change is backward compatible as the respone.finished is not removed yet. Fixes: #3428
github-actions
bot
added
agent-nodejs
david-luna
requested changes
Jun 19, 2023
Co-authored-by: David Luna <david.luna@elastic.co>
david-luna
requested changes
Jun 21, 2023
Co-authored-by: David Luna <david.luna@elastic.co>
david-luna
reviewed
Jul 6, 2023
david-luna
approved these changes
Jul 6, 2023
|
@elasticmachine, run elasticsearch-ci/docs |
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
elastic#3430) * fix: Start supporting response.writableEnded in transaction's context. Since response.finished property is deprecated as of the newer node versions and another property i.e. response.writableEnded is currently used in place of it. So start supporting reponse.writableEnded in transcation's context. Also, the change is backward compatible as the respone.finished is not removed yet. Fixes: elastic#3428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since response.finished property is deprecated as of the newer node versions and another property i.e. response.writableEnded is currently used in place of it. So started supporting the response.writableEnded in transaction's context. Also, the change is backward compatible as the response.finished is not removed yet.
Fixes: #3428
Checklist