chore(deps-dev): bump the eslint group with 2 updates #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps the eslint group with 2 updates: [eslint](https://github.com/eslint/eslint) and [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import). Updates `eslint` from 9.9.1 to 9.10.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.9.1...v9.10.0) Updates `eslint-plugin-import` from 2.29.1 to 2.30.0 - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.29.1...v2.30.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-7e4ff2d463
branch
from
e214607
to
59f1d56
Compare
|
The lint failure: is something to do with: import-js/eslint-plugin-import#3005 due to this package-lock update: "node_modules/eslint-module-utils": {
- "version": "2.8.0",
- "resolved": "https://registry.npmjs.org/eslint-module-utils/-/eslint-module-utils-2.8.0.tgz",
- "integrity": "sha512-aWajIYfsqCKRDgUfjEXNN/JlrzauMuSEy5sbd7WXbtW3EH6A6MpwEh42c7qD+MqQo9QMJ6fWLAeIJynx0g6OAw==",
+ "version": "2.11.0",
+ "resolved": "https://registry.npmjs.org/eslint-module-utils/-/eslint-module-utils-2.11.0.tgz",
+ "integrity": "sha512-gbBE5Hitek/oG6MUVj6sFuzEjA/ClzNflVrLovHi/JgLdC7fiN5gLAY1WIPW1a0V5I999MnsrvVrCOGmmVqDBQ==",
"dev": true,I haven't dug into why. |
|
For example, if we remove usage of the diff --git a/eslint.config.js b/eslint.config.js
index c05b5de4..a2e1c0a3 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -10,7 +10,8 @@ const prettierConfig = require('eslint-config-prettier');
const licenseHeaderPlugin = require('eslint-plugin-license-header');
const nPlugin = require('eslint-plugin-n');
const promisePlugin = require('eslint-plugin-promise');
-const importPlugin = require('eslint-plugin-import');
+// XXX
+// const importPlugin = require('eslint-plugin-import');
const prettierPlugin = require('eslint-plugin-prettier');
module.exports = [
@@ -59,7 +60,7 @@ module.exports = [
'license-header': licenseHeaderPlugin,
n: nPlugin,
promise: promisePlugin,
- import: importPlugin,
+ // import: importPlugin,
prettier: prettierPlugin,
},
rules: {
@@ -102,15 +103,15 @@ module.exports = [
'promise/param-names': ['error'],
// Undo this config from eslint:recommended for now (standardjs didn't have it.)
'require-yield': ['off'],
- 'import/export': 'error',
- 'import/first': 'error',
- 'import/no-absolute-path': [
- 'error',
- { esmodule: true, commonjs: true, amd: false },
- ],
- 'import/no-duplicates': 'error',
- 'import/no-named-default': 'error',
- 'import/no-webpack-loader-syntax': 'error',
+ // 'import/export': 'error',
+ // 'import/first': 'error',
+ // 'import/no-absolute-path': [
+ // 'error',
+ // { esmodule: true, commonjs: true, amd: false },
+ // ],
+ // 'import/no-duplicates': 'error',
+ // 'import/no-named-default': 'error',
+ // 'import/no-webpack-loader-syntax': 'error',
// Some defaults have changed in v9
'dot-notation': ['error'],
'new-cap': ['error', { capIsNew: false }],then lint works again. |
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/eslint-7e4ff2d463
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the eslint group with 2 updates: eslint and eslint-plugin-import.
Updates
eslintfrom 9.9.1 to 9.10.0Release notes
Sourced from eslint's releases.
Changelog
Sourced from eslint's changelog.
Commits
6448f329.10.0afeb9b1Build: changelog update for 9.10.024c3ff7chore: upgrade to@eslint/js@9.10.0 (#18866)1ebdde1chore: package.json update for@eslint/jsrelease301b90dfeat: Add types (#18854)bee0e7adocs: update README (#18865)bcf0df5feat: limit namespace import identifier in id-length rule (#18849)45c18e1feat: addrequireFlagoption torequire-unicode-regexprule (#18836)5d80b59docs: specify thatruleIdcan benullin custom formatter docs (#18857)156b1c3docs: Update READMEUpdates
eslint-plugin-importfrom 2.29.1 to 2.30.0Release notes
Sourced from eslint-plugin-import's releases.
... (truncated)
Changelog
Sourced from eslint-plugin-import's changelog.
Commits
18787d3Bump to 2.30.09902298[Deps] updateeslint-module-utils9d194a6[utils] v2.9.00a58d75[resolvers/webpack] v0.13.9a3015eb[Test]namespace: ensure valid case is actually included8bdb32b[Test] add explicit marker for trailing whitespace in cases038c26c[readme] Clarify how to install the plugin32a2b89[Fix]order: do not compare first path segment for relative paths (#2682)ee1ea02[Fix]newline-after-import: fix considerComments option when require806e3c2[New] add support for Flat ConfigMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions