Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(updatecli): add policies autodiscovery, bump updatecli version and specs/jsons policies #4338

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 2, 2024

What

  • Use the latest updatecli version for now
  • Update policies for the specs/jsons
  • Enable updatecli policies autodiscovery (but use the previous latest one, so I can test this PR)

Why

Otherwise, elastic/apm-agent-go#1671 won't work

🐔 🥚 since https://github.com/updatecli/updatecli/releases/tag/v0.86.0

Sources were always executed before conditions and then targets.
With this change, sources, conditions, and targets can now depend on any other resource type to allow an advanced update scenario.

And there are errors like

target: target#agent-json-specs
-----------------------

**Dry Run enabled**

The shell 🐚 command "/bin/sh /tmp/updatecli/bin/68b2939c124c411192667268d8f6edefbaa79f085494796eb8122c21afdb37bf.sh" exited on error (exit code 2) with the following output:
----
----

command stderr output was:
----
tar (child): /home/runner/work/apm-agent-go/apm-agent-go/json-specs.tgz: Cannot open: No such file or directory

Test

See https://github.com/elastic/apm-agent-nodejs/actions/runs/12117832379

@v1v v1v marked this pull request as ready for review December 2, 2024 10:55
@v1v v1v requested a review from a team December 2, 2024 10:55
@v1v v1v self-assigned this Dec 2, 2024
@v1v v1v merged commit 70debfb into main Dec 2, 2024
18 checks passed
@v1v v1v deleted the feature/update-cli-things branch December 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants