chore: update @apollo/server to v5
#4771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
david-luna
commented
Sep 25, 2025
| var name = | ||
| queries.length > 0 ? queries.join(', ') : 'Unknown GraphQL query'; | ||
| if (trans.req) var path = getPathFromRequest(trans.req, true); | ||
| if (trans.req) var path = getPathFromRequest(trans.req, true, true); |
There was a problem hiding this comment.
note to reviewer: The 3rd param is to use the path as transaction name and makes the test pass but I?m not 100% sure about the implications of changing this.
There was a problem hiding this comment.
I don't either. The tests are only testing cases where the path is '/', so kinda hard to know if there are real implications.
usePathAsTransactionName is in general dangerous because it can lead to high cardinality transaction names. But I'm not sure if that is a real concern for GraphQL endpoints where I think the GraphQL calls are all hanging off of a single HTTP path.
🔍 Preview links for changed docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist