Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about typescript import #638

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Oct 26, 2018

Typescript removes unused imports, so we should recommend using the -r elastic-apm-node/start loading method instead.

Fixes #608

Typescript removes unused imports, so we should recommend using
the `-r elastic-apm-node/start` loading method instead.

Fixes elastic#608
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You've been on fire yesterday 💯

@watson watson merged commit 61f2ca4 into elastic:master Oct 26, 2018
@Qard Qard deleted the typescript-import-note branch October 26, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants