Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update User-Agent to match spec #1378

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Update User-Agent to match spec #1378

merged 8 commits into from
Nov 8, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Nov 3, 2021 •
edited
Loading

What does this pull request do?

Updates the User-Agent header to match the spec in elastic/apm#514

Remaining:

Related issues

Closes #1355

@apmmachine
Copy link
Contributor

apmmachine commented Nov 3, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-08T15:15:07.203+0000

  • Duration: 34 min 42 sec

  • Commit: da07d12

Test stats 🧪

Test Results
Failed 0
Passed 10175
Skipped 8977
Total 19152

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@basepi basepi marked this pull request as ready for review November 5, 2021 16:05
@basepi basepi requested a review from beniwohli November 5, 2021 16:05
beniwohli
beniwohli approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basepi
Copy link
Contributor Author

basepi commented Nov 8, 2021

/test

@basepi basepi merged commit f08081c into elastic:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beniwohli beniwohli beniwohli approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 527] User-agent header for transport
3 participants
@basepi @apmmachine @beniwohli