Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate specs update to updatecli #1375

Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 9, 2023

What

Migrate https://github.com/elastic/apm/blob/main/.ci/Jenkinsfile to the consumer using updatecli and GH Actions workflows.

Why

Jenkins 2 GH Actions Migration

How to test

export GITHUB_TOKEN="<your-personal-access-token>"
export GIT_USER="FooBar"
export GIT_EMAIL="foo@bar.com"
updatecli --config .ci/updatecli.d/update-json-specs.yml diff
updatecli --config .ci/updatecli.d/update-gherkin-specs.yml diff

@reakaleek reakaleek self-assigned this Mar 9, 2023
@reakaleek reakaleek requested a review from a team March 9, 2023 14:24
@reakaleek reakaleek requested a review from a team March 9, 2023 14:25
@apmmachine
Copy link
Contributor

apmmachine commented Mar 9, 2023

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T06:25:03.928+0000

  • Duration: 28 min 10 sec

Test stats 🧪

Test Results
Failed 1
Passed 43542
Skipped 76
Total 43619

Test errors 1

Expand to view the tests failures

Tests / Tests / Ruby:docker.elastic.co/observability-ci/jruby:9.2-8-jdk#rails-6.0 / ElasticAPM::Metrics.collect_and_send when samples calls callback – when samples
    Expand to view the error details

     failed ElasticAPM::Metrics.collect_and_send when samples calls callback 
    

    Expand to view the stacktrace

     
            The message expectation for #<Proc:0x359fd0a2@/app/spec/elastic_apm/metrics_spec.rb:25 (lambda)>.call has already been invoked and cannot be modified further (e.g. using `at_least`). All message expectation customizations must be applied before it is used for the first time.
    ["./spec/elastic_apm/metrics_spec.rb:92:in `block in ElasticAPM'", "/usr/local/bundle/jruby/2.5.0/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block in /usr/local/bundle/jruby/2.5.0/gems/webmock-3.18.1/lib/webmock/rspec.rb'"]
           
    

Steps errors 4

Expand to view the steps failures

Shell Script
  • Took 5 min 53 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-jdk rails-6.0
Shell Script
  • Took 2 min 7 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-jdk rails-6.0
Shell Script
  • Took 2 min 10 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-jdk rails-5.2
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Ruby:docker.elastic.co/observability-ci/jruby:9.2-8-jdk#rails-6.0 tests failed : hudson.AbortException: script returned exit code 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Mar 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.231% (129/130) 👎 -0.006
Classes 99.231% (129/130) 👎 -0.006
Lines 66.28% (2858/4312) 👍 7.396
Conditionals 100.0% (0/0) 💚

@reakaleek reakaleek requested a review from v1v March 9, 2023 15:59
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise:

WARNING: **Fallback** Please add a title to you configuration using the field 'title: <your pipeline>'
Pipeline "update-jsons-specs" failed
Skipping due to:
	action stage:	"Title is too long (maximum is 256 characters)"

.ci/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-json-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-json-specs.yml Outdated Show resolved Hide resolved
@reakaleek reakaleek force-pushed the feature/migrate-specs-update-to-updatecli branch from 4672a67 to 2697593 Compare March 30, 2023 06:24
@reakaleek reakaleek requested a review from v1v March 30, 2023 06:24
@reakaleek
Copy link
Member Author

Force merging. The CI errors are unrelated to the changes.

@reakaleek reakaleek enabled auto-merge (squash) March 30, 2023 07:31
@reakaleek reakaleek disabled auto-merge March 30, 2023 07:31
@reakaleek reakaleek merged commit e5e346a into elastic:main Mar 30, 2023
@reakaleek reakaleek deleted the feature/migrate-specs-update-to-updatecli branch March 30, 2023 07:31
jclusso added a commit to jclusso/apm-agent-ruby that referenced this pull request Apr 13, 2023
* elastic/main: (30 commits)
  docs: remove kibana endpoint (elastic#1381)
  Update status badge (elastic#1379)
  Create single status check that can be set as required (elastic#1378)
  Remove jenkins related precommit hooks (elastic#1380)
  Migrate Jenkinsfile 2 GH Actions Workflow (elastic#1366)
  Migrate update specs to updatecli (elastic#1375)
  v4.6.2
  Fixing Faraday::RackBuilder::StackLocked (elastic#1371)
  Fix jruby docker images (elastic#1367)
  Update reference to sinatra main (elastic#1373)
  Update release:update_branch task to reference branch 4.x
  Add missing docs reference
  v4.6.1
  Add security options to docker containers (elastic#1356)
  Make sure http status code is set when Faraday Middleware is used (elastic#1368)
  Use composite action for updatecli workflow (elastic#1365)
  Fix sha source in updatecli update-specs.yml (elastic#1363)
  Add update-specs updatecli workflow (elastic#1359)
  use jruby user to run docker containers (elastic#1355)
  Close the read pipe at the right moment (elastic#1351)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants