Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use graphql < 2.1 when Ruby < 2.7 #1425

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Use graphql < 2.1 when Ruby < 2.7 #1425

merged 1 commit into from
Nov 24, 2023

Conversation

picandocodigo
Copy link
Member

@picandocodigo picandocodigo commented Nov 21, 2023

What does this pull request do?

Update the dependency on the graphql gem when using Ruby < 2.7 since version 2.1 is incompatible. Adjust version of google-protobuf for Ruby 2.6.

Why is it important?

To fix the build.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

Use google-protobuf < 3.25 when Ruby is 2.6
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency gymnastics...

@estolfo
Copy link
Contributor

estolfo commented Nov 22, 2023

@elasticmachine run elasticsearch-ci/docs

@picandocodigo picandocodigo merged commit 572058c into main Nov 24, 2023
57 checks passed
@picandocodigo picandocodigo deleted the update_graphl_dep branch November 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants