Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename addTags to addLabels #215

Closed
2 tasks done
hmdhk opened this issue Mar 15, 2019 · 1 comment
Closed
2 tasks done

Rename addTags to addLabels #215

hmdhk opened this issue Mar 15, 2019 · 1 comment
Assignees
@hmdhk
Labels
breaking change
Milestone
7.7

Comments

@hmdhk
Copy link
Contributor

hmdhk commented Mar 15, 2019 •
edited by vigneshshanmugam
Loading

  • remove addTags in major version.
  • Update docs

Related elastic/apm#42
@graphaelli graphaelli mentioned this issue Mar 15, 2019
Closed
7 tasks
@alvarolobato alvarolobato added this to the next milestone Mar 26, 2019
@vigneshshanmugam vigneshshanmugam mentioned this issue May 23, 2019
Merged
@vigneshshanmugam
Copy link
Member

Deprecation goes in minor/patch version. Removing the addTags goes in the next major version which is a breaking change.

@lreuven lreuven removed this from the next milestone Nov 17, 2019
@hmdhk hmdhk added this to the 7.6 milestone Dec 18, 2019
@hmdhk hmdhk modified the milestones: 7.6, 7.7 Feb 12, 2020
@hmdhk hmdhk self-assigned this Mar 3, 2020
This was referenced Mar 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmdhk hmdhk

Labels
breaking change
Projects
None yet
Milestone
7.7
Development

No branches or pull requests
4 participants
@lreuven @vigneshshanmugam @hmdhk @alvarolobato