Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove addTags method #698

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Conversation

hmdhk
Copy link
Contributor

@hmdhk hmdhk commented Mar 11, 2020

Part of #272 and #215

  • mention support fo boolean and number values for addLabels

mention support fo boolean and number values for addLabels
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nit. LGTM

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>
@vigneshshanmugam
Copy link
Member

Test failure is unrelated.

@vigneshshanmugam vigneshshanmugam merged commit 36acae0 into elastic:master Mar 12, 2020
v1v pushed a commit to v1v/apm-agent-rum-js that referenced this pull request Apr 6, 2020
* docs: remove addTags

mention support fo boolean and number values for addLabels

* Apply suggestions from code review

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
* docs: remove addTags

mention support fo boolean and number values for addLabels

* Apply suggestions from code review

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants