Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

feat: improve writev encoding performance #88

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Sep 30, 2019

Rather than using reduce and string concatentation, which creates many intermediary strings, use map and join instead which only creates an intermediary array and a single string allocation

This may fix issue #80.

Rather than using reduce and string concatentation, which creates many
intermediary strings, use map and join instead which only creates an
intermediary array and a single string allocation
@watson
Copy link
Contributor

watson commented Oct 1, 2019

I updated the PR description so that it doesn't automatically close the referenced issue as you wrote may. Thought that was better and allows you to manually close it if it works

@watson watson merged commit 6612815 into elastic:master Oct 1, 2019
@watson
Copy link
Contributor

watson commented Oct 1, 2019

FYI: I've released this in v9.0.0. Unless we make an 8.x branch and backport it to that, this will only make it into v3.x of the agent. But I don't deem this an important fix that requires us to backport it as it's a pretty crazy edge case that probably means you're using the agent wrong in the first place

@Qard Qard deleted the writev-perf-fix branch October 1, 2019 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants