This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
test-infra: beats-ci improvements #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
v1v
commented
May 14, 2020
| @@ -60,7 +60,7 @@ pipeline { | |||
| axes { | |||
| axis { | |||
| name 'PLATFORM' | |||
| values 'ubuntu && immutable', 'worker-c07l34n6dwym', 'worker-c07y20b6jyvy', 'worker-c07ll940dwyl', 'worker-c07y20b9jyvy', 'worker-c07y20b4jyvy', 'worker-c07y20bcjyvy', 'worker-395930', 'worker-0a434dec4bdcd060f', 'windows-immutable && windows-2019', 'windows-immutable && windows-2016', 'windows-immutable && windows-2012', 'windows-immutable && windows-7', 'windows-immutable && windows-7-32-bit', 'windows-immutable && windows-2008', 'windows-immutable && windows-2008-r2', 'windows-immutable && windows-10' | |||
| values 'ubuntu && immutable', 'worker-c07l34n6dwym', 'worker-c07y20b6jyvy', 'worker-c07ll940dwyl', 'worker-c07y20b9jyvy', 'worker-c07y20b4jyvy', 'worker-c07y20bcjyvy', 'worker-395930', 'worker-0a434dec4bdcd060f', 'windows-immutable && windows-2019', 'windows-immutable && windows-2016', 'windows-immutable && windows-2012', 'windows-immutable && windows-10', 'windows-immutable && windows-8', 'windows-immutable && windows-2008-r2', 'windows-immutable && windows-7', 'windows-immutable && windows-7-32-bit' | |||
There was a problem hiding this comment.
There was typo 'windows-immutable && windows-2008', rather than 'windows-immutable && windows-8',
Then I sorted based on the windows numbering
Comment on lines
-131
to
-139
| def testDockerInside(){ | ||
| docker.image('node:12').inside(){ | ||
| dir("${BASE_DIR}"){ | ||
| withEnv(["HOME=${env.WORKSPACE}"]){ | ||
| sh(script: './resources/scripts/jenkins/build.sh') | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
got a bug when running in two nested BASE_DIR folders, so to avoid issues I moved the body where the call happens.
Comment on lines
+13
to
+14
| cmd = host.run("tar --version") | ||
| assert cmd.rc == 0, "it is required for the stashV2 and unstashV2 steps" |
There was a problem hiding this comment.
Required since elastic/beats#18473 will be merged sooner than later
….com:v1v/apm-pipeline-library into feature/beats-ci-add-dependencies-test-infra * 'feature/beats-ci-add-dependencies-test-infra' of github.com:v1v/apm-pipeline-library: [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.97
v1v
commented
May 14, 2020
| @@ -116,24 +124,20 @@ def runTest(){ | |||
| if (uname.startsWith("Darwin")) { | |||
| sh(returnStatus: true, script: './resources/scripts/jenkins/beats-ci/test-mac.sh') | |||
| } else { | |||
| // worker-0a434dec4bdcd060f does not have any reference repos | |||
| def runPackerCacheTests = PLATFORM.equals('worker-0a434dec4bdcd060f') ? 'false' : 'true' | |||
There was a problem hiding this comment.
To avoid running the testsuite for the git reference repos
cachedout
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Make the test-infra our way to check for healthy workers
Related issues
Closes #ISSUE