-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format to Kibana index pattern #3751
Comments
No, I talked to @thomasneirynck about that field but I have no idea where it's coming from. I don't think we should rely on it being available to end users. |
thx @simitt for raising. This will help the display of the legend, tooltip-values, and text-labels of the default Observability layers in Maps. wrt cc @nreese |
Sorry, I can't help on this |
@thomasneirynck It feels like this conversation may be going in a very different direction, but while we have this group, can we get some confirmation on the fields in use? We just merged a feature that utilizes out of the box APM fields and got the 👌 from @drewpost and @cyrille-leclerc, so I thought we were OK here. There's more detail in this meta issue (elastic/kibana#64445), but I've listed the fields we're using below. It sounds like APM - Real User Monitoring - Performance & Traffic
APM - Real User Monitoring - Performance
APM - Real User Monitoring - Traffic
|
|
The field |
Thanks for confirming @gingerwizard @sqren. |
I created a PR for the format changes for |
thx @simitt for the update and linking to the older threads. Yes, let's see where this goes. I don't know enough about the APM-space to know if this will negatively affect Discover-users of APM-data. The Maps-app right now only formats using index-pattern formatters, so +1 on following general recommendation here. It's just that for labeling our clusters or boundaries, those micro-second labels look really large ;) |
I'll go out on a tangent and write my observation of generic Kibana apps vs Solutions:
Isn't this where the solution should make an opinionated decision and use the format that makes sense in the given context? |
agreed on that. and to be clear: I'm not suggesting this needs to change for any of the existing display in APM. I just wanted to highlight that for Map-labels, it helps if we can provide some context to what those values are (e.g. "ms" ...). It's a technical limitation right now that Maps needs to use field-formatters. This need for special treatment in Solutions is shared btw. E.g. the SIEM-app plugs in their own custom formatters when they are using the MapsEmbeddable to show their custom tooltips on the map. |
Just to confirm while we're working through the field names. Are these the default geo_ip enriched geo fields for RUM?
|
@alexfrancoeur Yes, that looks correct. You can find all the fields here: https://github.com/elastic/apm-server/blob/d8440540e2d2d6a2e9db74627d92fb3c7587e631/docs/fields.asciidoc
|
@thomasneirynck if you don't object, I'd like to close this issue for above discussed reasons (avoiding confusion by providing a different formater than what the field name actually suggests). |
+1, thx @simitt |
According to elastic/kibana#64949 (comment) following formats should be added:
All of the changes need to be made in APM Server
fields.yml
files, and then be properly processed from libbeat fields creator. Beats supports theFormat
field and theInputFormat
,OutputFormat
andOutputPrecision
which seem to cover the requirements for these changes.@elastic/apm-ui there is no field
duration_sla_pct
in the index pattern/index template in APM Server. Is this some calculated field from the UI?cc @thomasneirynck
The text was updated successfully, but these errors were encountered: