Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround to disable aggregation on GOARCH=386 #11393

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Aug 15, 2023

Motivation/summary

Temporary workaround to disable aggregation on GOARCH=386 to stop builds failing. No changelog as this is just a temporary workaround.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #11394

Temporary workaround to make builds pass
@carsonip carsonip changed the title Disable aggregation on GOARCH=386 Workaround to disable aggregation on GOARCH=386 Aug 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 15, 2023
@carsonip carsonip marked this pull request as ready for review August 15, 2023 08:36
@carsonip carsonip requested a review from a team as a code owner August 15, 2023 08:36
@carsonip carsonip requested a review from axw August 15, 2023 08:41
@carsonip carsonip enabled auto-merge (squash) August 15, 2023 08:45
@carsonip carsonip changed the title Workaround to disable aggregation on GOARCH=386 Temporary workaround to disable aggregation on GOARCH=386 Aug 15, 2023
@carsonip carsonip merged commit a2c4068 into elastic:main Aug 15, 2023
v1v added a commit that referenced this pull request Aug 16, 2023
…om-jenkins

* upstream/main:
  buildkite: package definition (#11399)
  chore: ran shell command ".ci/scripts/update-beats.sh 59529de17b77" (#11398)
  [updatecli] Bump elastic stack version to 8.10.0-8527fe43 (#11395)
  Create catalog-info file (#11373)
  Temporary workaround to disable aggregation on GOARCH=386 (#11393)
  Add back aggregation overflow logging (#11392)
  chore: ran shell command ".ci/scripts/update-beats.sh 6b76cfef012c" (#11391)
  [updatecli] Bump elastic stack version to 8.10.0-0aabd193 (#11389)
  Update apm-data and apm-aggregation (#11386)
  chore: ran shell command ".ci/scripts/update-beats.sh 4506e55d50f9" (#11384)
  [updatecli] Bump elastic stack version to 8.10.0-22c6ae41 (#11382)
  chore: ran shell command ".ci/scripts/update-beats.sh 942cd60d984b" (#11378)
  [updatecli] Bump elastic stack version to 8.10.0-46c2dc52 (#11377)
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
)

Workaround to disable aggregation on GOARCH=386 to stop builds failing. No changelog as this is just a temporary workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants