Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set processor.event for logs #11494

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

axw
Copy link
Member

@axw axw commented Aug 28, 2023

Motivation/summary

This is not used in any queried made by the APM UI, and is an APM-specific field that we should phase out. By removing it from logs, we can potentially write logs to non-APM specific log datastreams.

See also elastic/kibana#161718

Checklist

- [ ] Update CHANGELOG.asciidoc

  • Update package changelog.yml (only if changes to apmpackage have been made)
    - [ ] Documentation has been updated

How to test these changes

  1. Send some traces and logs, e.g. using https://github.com/elastic/apm-server/tree/main/systemtest/cmd/sendotlp
  2. Check that the logs data stream does not have a processor.event field
  3. Check that the logs still show up in the APM UI

Related issues

elastic/kibana#161718

This is not used in any queried made by the
APM UI, and is an APM-specific field that we
should phase out. By removing it from logs,
we can potentially write logs to non-APM
specific log datastreams.
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2023

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 28, 2023
@axw axw added the v8.11.0 label Aug 28, 2023
@axw axw marked this pull request as ready for review August 28, 2023 07:17
@axw axw requested a review from a team as a code owner August 28, 2023 07:17
@axw axw enabled auto-merge (squash) August 28, 2023 08:22
@axw axw merged commit b623546 into elastic:main Aug 28, 2023
7 checks passed
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
This is not used in any queried made by the
APM UI, and is an APM-specific field that we
should phase out. By removing it from logs,
we can potentially write logs to non-APM
specific log datastreams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants