-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog: document apm_user role removal breaking change #15197
base: main
Are you sure you want to change the base?
Conversation
f036ecb
to
78c2f5f
Compare
This pull request does not have a backport label. Could you fix it @endorama? 🙏
|
|
changelogs/head.asciidoc
Outdated
- Elasticsearch `apm_user` role has been removed. After this change additional permissions are required for Tail Based Sampling. | ||
For more details, see https://github.com/elastic/apm-server/pull/14876[PR #14876] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change additional permissions are required for Tail Based Sampling
I think the wording is a bit confusing 😓
The requirements for tbs didn't change. A user will have to specify permission manually if they are relying on apm_user
but that would be implicit by Elasticsearch
apm_user role has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clarified the sentence. It's true that the removal implies those permissions would be required, but I think better clear than having users not address this change.
Do you think the reference to TBS is needed? Something like "after this change, if you are relying on apm_user
for TBS permissions..."
Motivation/summary
Add a changelog entry for
apm_user
role removal, which is a breaking change affecting Tail Based Sampling.Checklist
For functional changes, consider:
How to test these changes
Related issues
#14859