Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: ECS for 6.x #1609
model: ECS for 6.x #1609
Changes from all commits
a6af765
701050d
ceeffdb
99c19c7
75a4085
4c40f12
bb6dd7b
e122d1d
3a7330a
4c4f153
4702718
1b24cdd
5f5110f
bbd74c5
1623c46
a1691ff
db16a71
8430094
3ce04c0
bd15cba
eb87599
c72fbd1
fe3f320
444fbf8
81303c6
2948e80
8e8880b
b444e4b
6301a52
9526e03
7c83ca4
da90de7
5ebf75e
629356d
c45b98d
2a8fecf
1004b8f
a548225
cd12363
304bcc7
fb54f5e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webmat I wonder if we should allow to nest
url
also underrequest
. Feels pretty natural.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's only one URL in the event, I don't see a reason to do move it around.
We need to control in how many places things can be nested. Each time we do this, we're growing the amounts of expected places that fields can be found in ECS, which is contrary to ECS' goal of making things easier to find across data sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user_agent.original.text
would be a multi-field, which is defined in the context of the "real" field, which isuser_agent.original
in this case.I guess we're hitting a corner case here. The field (in terms of setting an alias) is moving to
user_agent.original
. I'm not sure it's possible to create an alias to a multi-field. We need to look into this.But the usage side, if APM intends to use this as "what field does the query target", then yeah it's now
user_agent.original.text
.cc @ruflin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can alias to a multi-field but not back from a multi-field (marked as a non-reversible alias)