-
Notifications
You must be signed in to change notification settings - Fork 539
geoip system tests #18325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
geoip system tests #18325
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6a542c3
download geoip db instead of mounting
rubvs fe23bf5
add geoip enrichment system tests
rubvs 98445c7
cleanup logs
rubvs d1f7e29
add empty ip address to enrichment fail test
rubvs 7045b25
add geoip availablility system tests
rubvs 83a2a8d
copy network cfg in container recreation
rubvs 7509e8f
leverage the testing pkg
rubvs ea1286b
test: add lazy geoip downloader for rum
rubvs 1a20fb2
remove pre-downloading geoip database
rubvs 6623ae1
remove geoip db files for mounting
rubvs 5c093c2
add lazy downloader to system tests that require geoip db
rubvs 6dafb9e
fix formating
rubvs 910da49
move lazy geoipdb download to test setup
rubvs 72e46f0
localize struct type
rubvs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,6 @@ package systemtest | |
| import ( | ||
| "bytes" | ||
| "context" | ||
| "encoding/json" | ||
| "errors" | ||
| "fmt" | ||
| "io" | ||
|
|
@@ -52,6 +51,8 @@ const ( | |
|
|
||
| var ( | ||
| systemtestDir string | ||
| agentImageMu sync.RWMutex | ||
| agentImages = make(map[string]bool) | ||
| ) | ||
|
|
||
| func initContainers() { | ||
|
|
@@ -435,18 +436,6 @@ func (c *ElasticAgentContainer) Exec(ctx context.Context, cmd ...string) (stdout | |
| return stdoutBuf.Bytes(), stderrBuf.Bytes(), nil | ||
| } | ||
|
|
||
| func matchFleetServerAPIStatusHealthy(r io.Reader) bool { | ||
| var status struct { | ||
| Name string `json:"name"` | ||
| Version string `json:"version"` | ||
| Status string `json:"status"` | ||
| } | ||
| if err := json.NewDecoder(r).Decode(&status); err != nil { | ||
| return false | ||
| } | ||
| return status.Status == "HEALTHY" | ||
| } | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused code. cleanup. |
||
|
|
||
| // BuildElasticAgentImage builds a Docker image from the published image with a locally built apm-server injected. | ||
| func BuildElasticAgentImage( | ||
| ctx context.Context, | ||
|
|
@@ -478,8 +467,3 @@ func BuildElasticAgentImage( | |
| agentImages[arch] = true | ||
| return nil | ||
| } | ||
|
|
||
| var ( | ||
| agentImageMu sync.RWMutex | ||
| agentImages = make(map[string]bool) | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.