Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] approvals: use go-cmp instead #2969

Merged
merged 2 commits into from
Nov 27, 2019
Merged

[7.x] approvals: use go-cmp instead #2969

merged 2 commits into from
Nov 27, 2019

Commits on Nov 27, 2019

  1. approvals: use go-cmp instead 

    gojsondiff is unusably slow when comparing
large maps with many differences. I triggered
this in the profile integration tests, when
the `profile.id` field changed in every single
document. Use go-cmp instead, which is much faster.
    @axw
    axw committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    9a63e2b View commit details
    Browse the repository at this point in the history

  2. vendor: remove gojsondiff and friends

    @axw
    axw committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    a573489 View commit details
    Browse the repository at this point in the history