Instrument kibana client with apm go agent #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
- Coverage 79.36% 78.96% -0.40%
==========================================
Files 108 107 -1
Lines 5698 5582 -116
==========================================
- Hits 4522 4408 -114
+ Misses 1176 1174 -2
|
axw
approved these changes
Feb 20, 2020
graphaelli
reviewed
Feb 21, 2020
This was referenced Feb 24, 2020
Add elastic apm instrumentation to kibana client, and add context passing to all client methods. closes elastic#3185
Co-Authored-By: Gil Raphaelli <g@raphaelli.com>
simitt
force-pushed
the
instrument-kibana
branch
from
991cf6f to
983f6ce
Compare
|
Sorry for all the noise on this PR. I updated to the latest beats framework that now includes passing the context around. This is ready for final review/merge now. |
axw
approved these changes
Feb 25, 2020
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Feb 25, 2020
Add elastic apm instrumentation to kibana client, and add context passing to all client methods. closes elastic#3185
simitt
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This adds elastic apm instrumentation to the kibana client, and adds context passing to all client methods.
This change allows to gain more insights into outgoing requests to Kibana, as part of the Agent Configuration endpoint. For the moment it adds instrumentation to the APM Server code only, but once the instrumentation is also added to beats, the
apmhttpauto-instrumentation can be leveraged for outgoing calls.closes #3185
Checklist
- [ ] I have signed the Contributor License Agreement.make check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentationHow to test these changes
Start APM Server with
rumandkibanaenabled, and start the Elastic Stack. Make a request to the agent config endpoint, e.g.curl -i "http://localhost:8200/config/v1/agents?service.name=123"and ensure the outgoing request to Kibana is recorded.Related issues
closes #3185