Duplicate common fields

[jalvz]

Motivation/summary

This copies all the fields in fields.common.yml to the _meta/fields.yml files of each type.
This is needed for the APM integration, particularly for docs as they will be generated out of thefields.yml files of each type.
This results in duplicated fields.

Checklist

• I have signed the Contributor License Agreement.
• I have updated CHANGELOG.asciidoc

I have considered changes for:

• documentation
• logging (add log lines, choose appropriate log selector, etc.)
• metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)
• automated tests (add tests for the code changes, all unit tests pass locally)
• telemetry
• Elasticsearch Service (https://cloud.elastic.co)
• Elastic Cloud Enterprise (https://www.elastic.co/products/ece)
• Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)

How to test these changes

Run setup template and check that is unchanged.

Related issues

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: [Pull request #4446 updated]

• Start Time: 2020-11-20T08:05:25.354+0000

• Duration: 46 min 24 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4752
Skipped	143
Total	4895

Steps errors

Expand to view the steps failures

Compress

• Took 0 min 0 sec . View more details on here
• Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

Compress

• Took 0 min 0 sec . View more details on here
• Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

Test Sync

• Took 3 min 9 sec . View more details on here
• Description: ./script/jenkins/sync.sh

[simitt]

Not a big thing, but as soon as we add the data_stream fields here they will be in the template and show up at the docs. Do we really want this at this point? Why do we need the fields here already?

[jalvz]

This comes from merging @axw changes, so I'll summon him to answer this questions :)

(I personally think it is ok thou, as that is always the case for any new fields added - they show up in the master docs before the actual release)

[simitt]

Right, we already have the fields in the templates. I got confused with having the fields in the dedicated base-field.yml in the other PR.

Will take this to an offline discussion about why we introduced the fields.

[jalvz]

I got confused with having the fields in the dedicated base-field.yml in the other PR.

Totally reasonable!

[axw]

I probably should not have added those fields as they're really only meaningful when running under Agent. We can remove them in a followup, as there will probably be some fallout in tests.

[jalvz]

cc @bmorelli25 field reference docs will look different because of this, there is no longer a "common fields" section, instead all fields are duplicated for each type (transaction, span, etc) - Like beats does. Let me know if you spot something odd!

[axw]

I ran apm-server export template for 7.10 and 7.11 BC1, and compared them. The differences were:

• various ECS field additions
• various ECS fields changed from keyword to wildcard
• removal of the accidental "tracing" ECS fields
• labels_string, labels_boolean, and labels_* dynamic templates are repeated. This seems undesirable. I'll open an issue for that, otherwise looks good.

[axw]

Opened #4576